#286 - fix hang when >1 Camomile LV2 plugin is loaded on Linux #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript Two improvements: * All uses of the `-r` option have been changed to `-R` because this is portable across Linux and OSX. * When copying the contents of the plugin dir to the build dir, specify `-L` so that the user can have symbolic links in the plugin dir pointing to patches stored elsewhere. With `-L`, the patches will be copied, not the links.
…erence-symlinks-when-copying Improve the behaviour of cp commands in camomile plugin generation script
…ult-saving-presets makePresetsFile(): plugin parameters should be indexed by j, not i
…ierreguillot#286) This issue was ultimately caused by an object buried in the JUCE code having an inappropriate scope - GCC made the object a "unique global symbol", which means there is only one instance across the current process. When multiple plugins were loaded, they all shared this instance, but did not share other relevant objects (from the JUCE code), causing havoc. The fix is to ban GCC from marking symbols as "unique global". Also set the C++ standard to be C++20 for the Camomile_LV2 meta-plugin, in line with the other meta-plugins.
hyperpenelope
force-pushed
the
dev/daw-hangs-when-loading-multiple-lv2-plugins
branch
from
dd9aa30
to
27a4a14
Compare
filipeborato
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was ultimately caused by an object buried in the JUCE code having an inappropriate scope - GCC made the object a "unique global symbol", which means there is only one instance across the current process. When multiple plugins were loaded, they all shared this instance, but did not share other relevant objects (from the JUCE code), causing havoc. See #286 for al the gory details.
The fix is to ban the compiler from marking symbols as "unique global".
Also set the C++ standard to be C++20 for the Camomile_LV2 meta-plugin, in line with the other meta-plugins.